-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EZProxy] I4788 ezproxy test #5726
base: main
Are you sure you want to change the base?
Conversation
this is a file that is supposed to allow a group of princeton IP address Co-authored-by: Beck Davis <[email protected]> Co-authored-by: Vickie Karasic <[email protected]> Co-authored-by: Kevin Reiss <[email protected]>
this was a missing file in config.txt that controls ip ranges Co-authored-by: Beck Davis <[email protected]> Co-authored-by: Vickie Karasic <[email protected]> Co-authored-by: Kevin Reiss <[email protected]>
Co-authored-by: Beck Davis <[email protected]> Co-authored-by: Francis Kayiwa <[email protected]> Co-authored-by: Kevin Reiss <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the EZproxy automation so we can rebuild our EZproxy servers! I had a couple of questions/suggestions, see below.
@@ -52,6 +34,13 @@ | |||
when: | |||
- running_on_server | |||
|
|||
- name: Ezproxy | install ezproxy startup script (requires root) | |||
ansible.builtin.command: /var/local/ezproxy/ezproxy -si |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this command create a file or install a service or something like? something we could use as a condition to make the command only run when it needs to? Then we wouldn't need the changed_when: false
. . . or at the least we could set changed_when:
to something more specific
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we get very little to go for what is does from the documentation 🤷
No description provided.