Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODEOWNERS #42

Merged
merged 2 commits into from
Feb 24, 2025
Merged

Conversation

Victor-Jung
Copy link
Member

@Victor-Jung Victor-Jung commented Feb 24, 2025

This PR adds a CODEOWNERS file where we can attribute code owners to specific parts of the project. All code owners of the files modified by a PR must review it. This provides an easy way to separate concerns for review and to control who can actually review the code.

Added

  • A CODEOWNERS file

PR Merge Checklist

  1. The PR is rebased on the latest devel commit and pointing to devel.
  2. Your PR reviewed and approved.
  3. All checks are passing.
  4. The CHANGELOG.md file has been updated.

@Victor-Jung Victor-Jung requested a review from Xeratec February 24, 2025 13:27
@Victor-Jung Victor-Jung self-assigned this Feb 24, 2025
Copy link
Member

@Xeratec Xeratec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I am just wondering on what granularity you plan to assign code owners?

@FrancescoConti
Copy link
Member

LGTM. I am just wondering on what granularity you plan to assign code owners?

IMHO owners should be clearly the two of you. If you want a Unibo person as well, my recommendation is @lukamac

@Victor-Jung
Copy link
Member Author

@FrancescoConti I don't want to spam @lukamac each time a PR opens. @lukamac, if you really want to, I can add you ofc.

@lukamac
Copy link
Contributor

lukamac commented Feb 24, 2025

I am a little dubious about the details. This looks to me like it is on the granularity of the repo. Would that mean who is in the CODEOWNERS file must approve each PR?

@Victor-Jung
Copy link
Member Author

@Xeratec For now just you and I globally. Later, if some ppl really become experts of some distincts parts of the code (extension or platform for instance). Then we can start allocating at a finer granularity.

@Victor-Jung
Copy link
Member Author

@lukamac Good question: with the proposed CODEOWNERS file Philip or I will need to approve the PR for it to be mergable.

@lukamac
Copy link
Contributor

lukamac commented Feb 24, 2025

I would say, at this point in time, I am not as active in the PR review process so I would not put myself in there. If this changes over time, we can easily add me.
@FrancescoConti would you agree?

@FrancescoConti
Copy link
Member

Sure, either way is fine for me

@Victor-Jung Victor-Jung merged commit 61d8c9d into pulp-platform:devel Feb 24, 2025
108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants