-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CODEOWNERS #42
Add CODEOWNERS #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I am just wondering on what granularity you plan to assign code owners?
IMHO owners should be clearly the two of you. If you want a Unibo person as well, my recommendation is @lukamac |
@FrancescoConti I don't want to spam @lukamac each time a PR opens. @lukamac, if you really want to, I can add you ofc. |
I am a little dubious about the details. This looks to me like it is on the granularity of the repo. Would that mean who is in the CODEOWNERS file must approve each PR? |
@Xeratec For now just you and I globally. Later, if some ppl really become experts of some distincts parts of the code (extension or platform for instance). Then we can start allocating at a finer granularity. |
@lukamac Good question: with the proposed CODEOWNERS file Philip or I will need to approve the PR for it to be mergable. |
I would say, at this point in time, I am not as active in the PR review process so I would not put myself in there. If this changes over time, we can easily add me. |
Sure, either way is fine for me |
This PR adds a CODEOWNERS file where we can attribute code owners to specific parts of the project. All code owners of the files modified by a PR must review it. This provides an easy way to separate concerns for review and to control who can actually review the code.
Added
PR Merge Checklist
devel
commit and pointing todevel
.CHANGELOG.md
file has been updated.