Cast '0 reset values to data type
#227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niwis
requested changes
Aug 23, 2024
There was a problem hiding this comment.
Thank you @michael-platzer! Only one suggested change to fix CI.
michael-platzer
force-pushed
the
michael-platzer/feature/cast-reset-values
branch
from
a0dbb49 to
26ab10e
Compare
niwis
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several of the modules in this repository allow the user to specify a custom data type. Yet, the reset value for data registers is always
'0, which causes linter errors if the data type is, for instance, an enum.This PR casts all
'0reset values for data registers to the respective data type (e.g.,T'('0)), thus avoiding linter warnings.