Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed crashing pulp domain #770

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Fixed crashing pulp domain #770

merged 1 commit into from
Aug 11, 2023

Conversation

mdellweg
Copy link
Member

Providing a default value for --domain lead to the domain subcommand group getting an invalid default_map.

fixes #769

Review Checklist:

  • An issue is properly linked. [feature and bugfix only]
  • Tests are present or not feasible.
  • Commits are split in a logical way (not historically).

@mdellweg
Fixed crashing pulp domain
a6d459b 
Providing a default value for --domain lead to the domain subcommand
group getting an invalid default_map.

fixes pulp#769
@mdellweg mdellweg marked this pull request as ready for review August 11, 2023 14:06
@mdellweg mdellweg enabled auto-merge (rebase) August 11, 2023 14:06
ggainey
ggainey approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@ggainey ggainey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to ask for an extension to our domain-tests to catch this - and discovered we don't have domain-tests. Opened #771 to fix that, let's leave this PR to fix the immediate problem.

@mdellweg mdellweg merged commit aa48741 into pulp:main Aug 11, 2023
12 checks passed
@patchback
Copy link

patchback bot commented Aug 11, 2023 •
edited
Loading

Backport to 0.21: 💚 backport PR created

✅ Backport PR branch: patchback/backports/0.21/aa487415d8f9dad1ec62cd1208cf0ad0f13924f5/pr-770

Backported as #772

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback bot mentioned this pull request Aug 11, 2023
Merged
3 tasks
@mdellweg mdellweg deleted the fix_default_map branch August 11, 2023 15:07
@patchback Patchback
Copy link

patchback bot commented Jan 12, 2024 •
edited
Loading

Backport to 0.20: 💚 backport PR created

✅ Backport PR branch: patchback/backports/0.20/aa487415d8f9dad1ec62cd1208cf0ad0f13924f5/pr-770

Backported as #863

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback bot mentioned this pull request Jan 12, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggainey ggainey ggainey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'pulp domain' leads to a stack trace when a default value for --domain is provided in the config file.
2 participants
@mdellweg @ggainey