Add domain support #673
Merged
Add domain support #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerrod3
force-pushed
the
domains
branch
5 times, most recently
from
80e4255 to
3355dad
Compare
gerrod3
force-pushed
the
domains
branch
3 times, most recently
from
2ca2677 to
97519bf
Compare
mdellweg
reviewed
Jun 11, 2024
| @@ -1,4 +1,4 @@ | |||
| pulpcore>=3.49.0,<3.55 | |||
| pulpcore>=3.49.0,<3.70.0 | |||
There was a problem hiding this comment.
That's a bit dangerous and I think we haven't yet officially decided to go with 3.70.
Given the bindings discussion, we might actually discuss a shorter window this time.
Comment on lines
-308
to
+323
| class UploadView(ViewSet, PackageUploadMixin): | ||
| class UploadView(PackageUploadMixin, ViewSet): |
There was a problem hiding this comment.
This looks like an unrelated change. Is it where the 200 -> 202 in the tests come from?
Are these unrelated bugfixes?
There was a problem hiding this comment.
This is me fixing the inheritance of the classes the to be in the correct order. The 200 -> 202 change comes from using the pulpcore OperationPostponedResponse instead of a normal response. It seems that twine doesn't mind whether it receives a 200 or 202.
| @@ -10,3 +10,4 @@ class PulpPythonPluginAppConfig(PulpPluginAppConfig): | |||
| label = "python" | |||
| version = "3.12.0.dev" | |||
| python_package_name = "pulp-python" | |||
| domain_compatible = True | |||
gerrod3
force-pushed
the
domains
branch
2 times, most recently
from
308aa94 to
128434b
Compare
fixes: pulp#668
dralley
reviewed
Jun 16, 2024
dralley
approved these changes
Jun 18, 2024
mdellweg
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #668
RBAC support is also coming, but this was getting big so I am going to break it up into two PRs to hopefully make reviewing easier.
TODO:- [x] Fix failing tests- [x] Add docs