Declare compatibility with pulpcore 3.70 #791
Conversation
gerrod3
force-pushed
the
370-compat
branch
5 times, most recently
from
82d2790 to
ce2cea5
Compare
|
|
||
|
|
||
| @extend_schema_field(OpenApiTypes.OBJECT) | ||
| class JSONObjectField(serializers.JSONField): |
There was a problem hiding this comment.
The reason this can be removed, I presume, because tfranzel/drf-spectacular#1095 was fixed?
There was a problem hiding this comment.
See my messages in pulp-dev (https://matrix.to/#/!aVApiNMtnstWbwDcVU:matrix.org/$GRdEDvdyB04MXXbc66NWVNhCaI_VgdnhUb2xuJ1OJWs?via=matrix.org&via=ctrl-c.liu.se&via=x9c4.spdns.org), but the tldr is that with 3.70 we are using a new version of the bindings generator. This new version introduces pydantic models to check the types, so the mismatch between what we say the field is in the api and what we accept causes errors in the new bindings. This previous change was because the ruby-bindings broke when drf-spectular updated, so I have no idea if the ruby bindings will break again when removing this, but they should also be using the new bindings generator so hopefully they don't.
gerrod3
force-pushed
the
370-compat
branch
3 times, most recently
from
ce4f29b to
1f4b07c
Compare
fixes: #784