-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn a few verb-only pytest fixtures into standard functions #4763
Conversation
76133e0
to
28495b7
Compare
I don't think we provide semantic versioning guarantees for test infrastructure? And any time we do test infra changes we often end up backporting it anyway, just to avoid incompatibility when future tests are added and backported.
IMO, if we do that, and just eat the extra dependency, then we might as well just delete the function entirely. There's no point having an alias for a function as simple as |
Well now here is the question in the wild: Do we consider the pytest-plugins of pulpcore (and others) to be part of the plugin api, and therefore subject to the deprecation policy? Having a goal to render |
I would say deprecate the fixtures, copy them to the utils and slowing switch tests over to importing the util functions. Once all the plugins have switched, then we can remove the fixtures. |
It's the lower bounds test that makes me think about proper deprecation and removal only in a breaking change release. |
@@ -1060,7 +1060,6 @@ def _add_to_filesystem_cleanup(path): | |||
pass | |||
|
|||
|
|||
@pytest.fixture(scope="session") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want this to stop being a fixture. It is using other fixtures.
This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution! |
This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details. |
[noissue]