-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix WorkerNameMetricsExporter to not export unless otel is enabled. #5869
Conversation
Am I understanding this correctly that the idea is to get rid of the following error in the logs?
|
I think that this piece shows one of the many side effects triggered by the improper configuration of OTEL. We should investigate why we still do report some metrics. Line 44 in cd2b35f
cc: @decko |
I still don't get, why this middleware is so special, it cannot be configured like any other in the django config. |
@mdellweg, we aim to pass custom attributes into the autoinstrumentation, such as the worker name (pid@socketname) and service name (pulp-app), to help users accurately interpret the metrics from the Prometheus database. For example, when running multiple pods and workers in a cloud environment, Prometheus (and its backup) cannot properly distinguish between metrics coming from different sources, making them interchangeable and hard to identify. To address this, it might be also beneficial to make this change on upstream. |
Yes - it makes the logs basically useless, as it repeats every...minute? or so? And, esp when doing development, means I have to repeatedly scan the traceback to see if it's "my" broken code traceback, or a meaningless error. |
I guess the real answer is here: But first and foremost, the OTEL is not holding the promise to not interfere when not configured, and this PR fixes that. |
I don't know - but I do know that we use this pattern in two other places in core, which is where I stole the pattern from:
Personally, I don't care how it gets fixed - but I need it fixed, like, now - this makes it really hard to develop/debug code. |
Changing things in the template requires rebuilding the containers, yeah? I am in the middle of testing a thing that requires a certain amount of data setup, and would rather not, honestly. |
e4f09a4
to
fb972cc
Compare
No description provided.