Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional output path parameter to sign and asign methods #5924

Closed
wants to merge 1 commit into from

Conversation

hstct
Copy link
Contributor

@hstct hstct commented Oct 22, 2024

This commit introduces an optional output_path parameter to the sign and asign methods, allowing signed content to be stored in a specified location. This helps with better handling and cleanup of temporary files.

closes #5923

This commit introduces an optional `output_path` parameter to the
`sign` and `asign` methods, allowing signed content to be stored in a
specified location. This helps with better handling and cleanup of
temporary files.

closes pulp#5923
@hstct
Copy link
Contributor Author

hstct commented Oct 22, 2024

For more context the related pulp_deb PR: pulp/pulp_deb#1142

@mdellweg
Copy link
Member

I am not particularly happy with this. Preferably the script should run in the working directory of the task that should be a subdirectory of settings.WORKING_DIRECTORY.
If that's not an option, passing the output dir as an environment variable is probably less disruptive to existing signing scripts.

Somehow this reminds me of #5913.

@hstct
Copy link
Contributor Author

hstct commented Oct 23, 2024

For more context the related pulp_deb PR: pulp/pulp_deb#1142

I am not particularly happy with this. Preferably the script should run in the working directory of the task that should be a subdirectory of settings.WORKING_DIRECTORY. If that's not an option, passing the output dir as an environment variable is probably less disruptive to existing signing scripts.

Somehow this reminds me of #5913.

Oh, you are right I'm able to achieve the same thing with the env variables but without making a change in pulpcore! This sounds preferable to me, so I will close this PR and issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow the signing service to provide an output for the sign script
2 participants