-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add advanced search options #77
base: main
Are you sure you want to change the base?
Conversation
I also wonder if we can omit the ascending/descending decision. I have a hard time imagining anyone would want to search for the oldest, least-starred, least-downloaded, least-relevant, or least-recently-updated packages. |
If its not too difficult to implement (well, it already is implemented), then I think its worth keeping. Maybe someone wants to just do some package exploring (least relevant, use a keyword to start and just explore I guess?), or find some underappreciated packages (least starred, least downloaded), or want to find some package that they find interesting to revive (oldest)? It certainly doesn't hurt to keep it, I think |
In those scenarios they could also sort for (e.g.) most stars, then jump to the end of the results. But I don't think it's a big problem; just throwing an idea out there. |
Yeah the fact that it already has the double arrows on the page results kind of renders the search order unnecessary. I don't know if the package metadata has anything at the moment but we might want to consider a "filter" option as well that could filter themes, Pulsar specific packages etc. Another idea I was thinking is the possibility of doing github style queries in the search. For example:
Definitely not anything essential though. |
I'm just here to say this seems really neat, from the screenshot alone! |
This PR adds the ability to take advantage of the additional query parameters that already exist on the backend when searching for packages. Letting users take full advantage of these features when on the web, not just within the editor.
Adds the ability to:
Sort Search Results by:
List the results in the direction:
The results just like the search text itself will remember what was selected prior to navigating to a page, and does properly effect the search results. They match the theme that's in use and are relatively responsive. (Although it may be worth looking at disabling these on smaller screens or having these options as an expandable view rather than always visible)
Closes #48