[blog] Add Modern Tree-sitter (part 2) post #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daeraxa
reviewed
Sep 27, 2023
docs/blog/20230927-savetheclocktower-modern-tree-sitter-part-2.md
Outdated
Show resolved
Hide resolved
|
This is really good and I don't think it is dry at all, I have only one tiny and optional comment to make, otherwise I would say it is good to go. |
|
Addressed. If/when you approve, please also land it, as I don't have write access on this repo. Thanks for the review! |
|
|
Daeraxa
approved these changes
Sep 27, 2023
|
Thanks for making those changes and making this post. I'll get the socials sorted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one talks about the features of the TextMate grammar system and why they're important to preserve.