deps: Update .github repo to latest (fix loading PRIVACY_POLICY.md) #267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran
pnpm up .github
with pnpm 7.x latest (pnpm 7.33.6).Update the commit hash for
.github
repo in ourpnpm-lock.yaml
PNPM lockfile, to fetch the latest revision of that repo.Revision before this PR is too old to include
PRIVACY_POLICY.md
. This PR's change should pull in thePRIVACY_POLICY.md
file, so we can display it on the website.Fixes #161, probably?
Details:
I believe what Meadow said about it is basically right.
To reiterate and perhaps clarify further:
pulsar-edit/.github
repo is pinned in the lockfile. This commit is from November 2022.pulsar-edit/.github
repo that is at least from December 2022 or newer, when thePRIVACY_POLICY.md
was added. See: https://github.com/pulsar-edit/.github/commits/main/PRIVACY_POLICY.md and pulsar-edit/.github@5d2498a.pnpm install --frozen-lockfile
(among other CLI arguments), so this dependency will not automatically be updated in CI. But generally I don't expectpnpm install
to mess with the lockfile, by default, other than to update to a new lockfile format but retaining the same dependencies/dependency version numbers, just recorded/laid out into the new format.pnpm up .github
, the issue is fixed for me locally. The@include
ofPRIVACY_POLICY.md
is working.pnpm up
could hang in some cases, maybe just with older pnpm (?), due to somegit ls-remote
command under the hood hanging and then silently failing??? So, maybe that was giving people trouble at some point? It went away for me after updating to latest pnpm and also deleting my caches, not sure which solved it if either, since I did both at the same time... Also, perhaps it was a network error or me being rate-limited. and it just "went away on its own"/only an intermittent issue in the first place?)pnpm dev
running before updating the dep, relying on the auto-reload feature? But the@include
s appear to be processed only once per run ofpnpm dev
and then retained for the rest of that run... So, one has to quit the dev server and runpnpm dev
again to load the newPRIVACY_POLICY.md
file into the@include
.