Fix indentation (also tweak newlines/whitespace) in CI workflow yaml files #284
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr: Some whitespace-only tweaks to this repo's CI yaml worfklow files.
I kinda expect most people won't care about this, but @savetheclocktower might care about the first commit in this PR, at least.
First commit in this PR branch:
Fixes an off bit of indentation in one of the workflow .yaml files, per @savetheclocktower's comment pointing it out in this comment: d747eda#r146063988. (I think I may have run into this before and chosen to ignore it at the time, but feels better to me now to fix it after all.)
Second commit in this PR branch (optional, reviewers tell me whether you'd like this removed):
Also normalizes use of newlines in the workflow.yaml files: Always a blank line in-between steps, no matter what. Makes things more uniform, tidy and skimmable without missing things, IMO. Since they might not have appeared to be separate steps if not looked at closely. Makes the reader pause and consider that these are separate and distinct steps. Good for distracted troubleshooting, which is most troubleshooting, IMO.
Also, Pulsar automatically stripped some trailing spaces in the process... I committed these as well.
Note: Potential third commit?: (reviewers let me know if you're interested in this being added to the repo. can keep things tidy when reviewing commit histories. And help to not discourage formatting improvements for fear of "polluting the blame history.")
Can add this as a
.git-blame-ignore-revs
file to keep the blame view clean and ignore these commits when trying to suss out what actually went wrong with these files in the future, if anything:.git-blame-ignore-revs file, click to expand):
See blog post if curious about ignoring commits in git blame: https://www.stefanjudis.com/today-i-learned/how-to-exclude-commits-from-git-blame/ Also official git docs: https://git-scm.com/docs/git-blame#Documentation/git-blame.txt---ignore-revs-fileltfilegt Also GitHub.com will use such a file automatically: https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view