ast: syntax errors for invalid fn invocation #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyobe
commented
Feb 18, 2025
nyobe
force-pushed
the
claire/syntax-errors-for-invalid-fn-invocation
branch
from
a363467 to
0b132e4
Compare
pgavlin
reviewed
Feb 19, 2025
nyobe
force-pushed
the
claire/syntax-errors-for-invalid-fn-invocation
branch
from
6a3bdc2 to
7425227
Compare
pgavlin
approved these changes
Feb 19, 2025
nyobe
force-pushed
the
claire/syntax-errors-for-invalid-fn-invocation
branch
from
de7eb74 to
94b20cf
Compare
nyobe
added a commit
that referenced
this pull request
Feb 27, 2025
The import loader accidentally returns a nil environment if it fails to parse. Ordinarily this shouldn't happen because we don't let you save an environment if it fails validation. However, #449 introduced syntax errors for invalid fn calls, so some environments that previously incorrectly validated will now fail, and if you import one of these environments, we panic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when a fn expr is invalid we fall back to parsing it as an object, which results in an object containing a
fn::key, which is otherwise illegal, instead of the expected call. This PR makes these incorrect usages emit syntax errors so that it's easier for the user to identify the mistake ahead of time, instead of after discovering that the function wasn't called.Case 1 - having an additional key in a fn call:
Case 2 - having a fn:: key as a toplevel key in values:
Resolves #447