cli: add a --string flag to env set #467
Conversation
seanyeh
force-pushed
the
pgavlin/env-set-string
branch
from
faacaa3 to
9e00b86
Compare
| @@ -57,8 +59,17 @@ func newEnvSetCmd(env *envCommand) *cobra.Command { | |||
| return fmt.Errorf("path must contain at least one element") | |||
| } | |||
|
|
|||
| input := args[1] | |||
| if rawString { | |||
| js, err := json.Marshal(input) | |||
There was a problem hiding this comment.
yaml.Node has a SetString helper that you can use, rather than this marshal/unmarshal round trip.
this also sets the block style automatically. a slight change lets us preserve that so we use the nicer block string syntax when there are newlines, rather than escaping them like the json marshaling does
There was a problem hiding this comment.
I worry that we need to be a little bit more sophisticated than SetString. That helper doesn't handle non-printable characters, for example (literal style scalars don't offer any escape sequences): https://github.com/go-yaml/yaml/blob/v3.0.1/yaml.go#L471-L483
We could use that method and then override the quoting style for strings with non-printable characters:
node.SetString(input)
if mustEscape := strings.ContainsFunc(input, func(r rune) bool { return !strconv.IsPrint(r) }); mustEscape {
node.Style = yaml.DoubleQuotedStyle
}
There was a problem hiding this comment.
it seems like they were trying to do it by falling back to base64 encoding if it !utf8.IsValid(), but if that's the wrong check then yeah, we should override the quoting style 👍
There was a problem hiding this comment.
Yeah that's not an adequate check. That'll catch invalid UTF-8 but not valid UTF-8 with non-printable chars.
| @@ -0,0 +1,10 @@ | |||
| run: | | |||
| esc env init default/test | |||
| esc env set default/test path "[a" --string | |||
There was a problem hiding this comment.
This test should also run an esc env get to ensure that the string's content is as expected
Add a
--stringflag toenv setto treat given value as a string