Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformatting everything with black and adding a test for it #1762

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Reformatting everything with black and adding a test for it #1762

merged 1 commit into from
Jan 10, 2025

Conversation

rshade
Copy link
Contributor

@rshade rshade commented Jan 9, 2025 •
edited
Loading

This PR reformats all the python files with black, so they have a uniform formatting. It adds a make command and test.

smithrobs
smithrobs approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@smithrobs smithrobs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like consistency 😄 Thanks for adding black.toml; LGTM

smithrobs
smithrobs requested changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@smithrobs smithrobs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm why did the one check fail? looks like test flake, nm

@rshade rshade merged commit 7ac82a7 into master Jan 10, 2025
41 checks passed
@rshade rshade deleted the no_docker_build branch January 10, 2025 14:40
@rshade rshade mentioned this pull request Jan 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smithrobs smithrobs smithrobs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rshade @smithrobs