Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify PF attr obj shim #2232

Draft
wants to merge 3 commits into
base: vvm/add_pf_shim_tests1
Choose a base branch
from

fix test

e316c27
Select commit
Loading
Failed to load commit list.
Draft

Simplify PF attr obj shim #2232

fix test
e316c27
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 23, 2024 in 0s

60.66% (+0.00%) compared to e46106b

View this Pull Request on Codecov

60.66% (+0.00%) compared to e46106b

Details

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Project coverage is 60.66%. Comparing base (e46106b) to head (e316c27).

Files Patch % Lines
pf/internal/schemashim/attr_schema.go 69.23% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           vvm/add_pf_shim_tests1    #2232   +/-   ##
=======================================================
  Coverage                   60.66%   60.66%           
=======================================================
  Files                         356      356           
  Lines                       46447    46459   +12     
=======================================================
+ Hits                        28176    28184    +8     
- Misses                      16711    16714    +3     
- Partials                     1560     1561    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.