Refactor PF detailed diff tests #2814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is part of the following stack:
Change managed by git-spice. |
This was referenced Jan 7, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2814 +/- ##
=======================================
Coverage 68.70% 68.70%
=======================================
Files 325 325
Lines 41621 41621
=======================================
Hits 28595 28595
Misses 11419 11419
Partials 1607 1607 ☔ View full report in Codecov by Sentry. |
VenelinMartinov
force-pushed
the
vvm/refactor_pf_detailed_diff_tests
branch
2 times, most recently
from
d903a8b to
e414e12
Compare
This was referenced Jan 7, 2025
Closed
VenelinMartinov
force-pushed
the
vvm/move_pf_detailed_diff_tests
branch
from
0e4fc2e to
d538ddb
Compare
VenelinMartinov
force-pushed
the
vvm/refactor_pf_detailed_diff_tests
branch
from
dbc1c2d to
8afea58
Compare
VenelinMartinov
force-pushed
the
vvm/move_pf_detailed_diff_tests
branch
from
d538ddb to
3e69b03
Compare
VenelinMartinov
force-pushed
the
vvm/refactor_pf_detailed_diff_tests
branch
from
8afea58 to
acc0f73
Compare
VenelinMartinov
force-pushed
the
vvm/move_pf_detailed_diff_tests
branch
from
3e69b03 to
89867cb
Compare
VenelinMartinov
force-pushed
the
vvm/refactor_pf_detailed_diff_tests
branch
from
acc0f73 to
7aadd5d
Compare
VenelinMartinov
force-pushed
the
vvm/refactor_pf_detailed_diff_tests
branch
from
7aadd5d to
06d6bb1
Compare
iwahbe
approved these changes
Jan 14, 2025
VenelinMartinov
added a commit
that referenced
this pull request
Jan 14, 2025
This PR refactors the SDKv2 detailed diff tests to make test sharding easier. The main problem was that TestDetailedDiffSet was too large. Very similar to what #2814 does for PF. This PR: - Moves the SDKv2 detailed diff tests to their own folder. This should make sharing code between them easier without exposing it to the other tests. - Splits up `TestDetailedDiffSet` into a few separate tests. This will allow the tests to be run on different shards. - Moves around some of the shared code into the `value_makers.go` file, instead of duplicating in each test. - Renames the tests to specify that they are for SDKv2 and renamed some of the utility functions to clarify what they do. [2c18440](2c18440) has test recordings, the rest are the changes. The test recording changes are all no-ops related to the change in the struct being recorded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the PF detailed diff tests to make test sharding easier. The main problem was that TestDetailedDiffSet was too large.
This PR:
TestDetailedDiffSetinto a few separate tests. This will allow the tests to be run on different shards.value_makers.gofile, instead of duplicating in each test.dbc1c2d has test recordings, the rest are the changes. The test recording changes are all no-ops related to the change in the struct being recorded.