Add skip diff equivalence flag for Diff cross-tests #2913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is part of the following stack: Change managed by git-spice. |
This was referenced Feb 25, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## vvm/diff_cross_tests_for_provider_upgrades #2913 +/- ##
==============================================================================
- Coverage 67.75% 67.74% -0.01%
==============================================================================
Files 331 331
Lines 42210 42210
==============================================================================
- Hits 28599 28597 -2
- Misses 12017 12020 +3
+ Partials 1594 1593 -1 ☔ View full report in Codecov by Sentry. |
VenelinMartinov
changed the base branch from
vvm/restore_prc_flag
to
vvm/diff_cross_tests_for_provider_upgrades
VenelinMartinov
force-pushed
the
vvm/add_skip_diff_equivalence_flag
branch
from
f838beb to
e02f522
Compare
VenelinMartinov
changed the title
VenelinMartinov
force-pushed
the
vvm/diff_cross_tests_for_provider_upgrades
branch
from
a144941 to
dc3f267
Compare
VenelinMartinov
force-pushed
the
vvm/add_skip_diff_equivalence_flag
branch
from
e02f522 to
2b70f09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
DiffSkipDiffEquivalenceCheckfor Diff cross-tests which allows a test to skip the check for equivalence between TF and Pulumi. This is useful to mark cases where there are known differences in behaviour.