Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(CAT-2051): Nightly build failure fixes for puppetlab-java module #597

Closed
wants to merge 1 commit into from
Closed

(CAT-2051): Nightly build failure fixes for puppetlab-java module #597

wants to merge 1 commit into from
+38 −23

Conversation

span786
Copy link
Contributor

@span786 span786 commented Sep 19, 2024 •
edited
Loading

The following issues were addressed:

  • Java installation was failing on SLES-15. To resolve this, a new condition was added for SLES 15.5 to check for java-11-openjdk instead of java-1_8_0-openjdk.
  • Support for aarch64 and arm64 was added for Adopt and Adoptium Java installations.
  • A condition was added for SAP Java to run only on x86_64 and amd64 architectures.

@span786 span786 requested review from bastelfreak and a team as code owners September 19, 2024 12:36
@span786 span786 force-pushed the CAT-2051-fixing-puppet-module_java-nightly-build-failures branch 2 times, most recently from f9de316 to 5add3cb Compare September 19, 2024 13:44
@span786 span786 marked this pull request as draft September 19, 2024 13:45
@span786 span786 force-pushed the CAT-2051-fixing-puppet-module_java-nightly-build-failures branch from 5add3cb to d4f4abd Compare September 19, 2024 13:51
@span786 span786 force-pushed the CAT-2051-fixing-puppet-module_java-nightly-build-failures branch from d4f4abd to 6b4980f Compare September 19, 2024 14:12
@span786 span786 marked this pull request as ready for review September 20, 2024 14:15
kenyon
kenyon reviewed Sep 20, 2024
View reviewed changes
Copy link
Contributor

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to split those changes into separate pull requests to make the commit history and changelog more useful.

@span786
Copy link
Contributor Author

span786 commented Sep 23, 2024

I am closing this PR as I plan to split the changes into separate PRs.

@span786 span786 closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenyon kenyon kenyon left review comments

@bastelfreak bastelfreak Awaiting requested review from bastelfreak bastelfreak is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@span786 @kenyon