Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MODULES-9914: physical_volumes provisioning with 'followsymlinks' #242

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CharlieR-o-o-t
Copy link

@CharlieR-o-o-t CharlieR-o-o-t commented Sep 16, 2019

This commit fixes broken physical device provisioning in case of symlink usage.
Jira issue: https://tickets.puppetlabs.com/browse/MODULES-9914

With 'followsymlinks' enabled we should have correct set of physical volumes (should, is) in order to compare it, and apply action.

Error example:
err /Stage[main]/Lvm/Lvm::Volume_group[vg1]/Volume_group[vg1]/physical_volumes change from ['/dev/sdb'] to ['/dev/disk/by-id/scsi-0QEMU_QEMU_HARDDISK_3243ac35-a879-4c26-b', '/dev/disk/by-id/scsi-0QEMU_QEMU_HARDDISK_0e99e7db-b97d-4017-a'] failed: Could not remove physical volume /dev/sdb from volume group 'vg1'; this physical volume may be in use and may require a manual data migration (using pvmove) before it can be removed (Execution of '/usr/sbin/vgreduce vg1 /dev/sdb' returned 5: Physical volume "/dev/sdb" still in use)

@CharlieR-o-o-t CharlieR-o-o-t changed the title Fix physical_volumes provisioning with 'followsymlinks' enabled Fix MODULES-9914: physical_volumes provisioning with 'followsymlinks' Sep 16, 2019
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Siarhei Rasiukevich seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants