Fix MODULES-9914: physical_volumes provisioning with 'followsymlinks' #242
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes broken physical device provisioning in case of symlink usage.
Jira issue: https://tickets.puppetlabs.com/browse/MODULES-9914
With 'followsymlinks' enabled we should have correct set of physical volumes (should, is) in order to compare it, and apply action.
Error example:
err /Stage[main]/Lvm/Lvm::Volume_group[vg1]/Volume_group[vg1]/physical_volumes change from ['/dev/sdb'] to ['/dev/disk/by-id/scsi-0QEMU_QEMU_HARDDISK_3243ac35-a879-4c26-b', '/dev/disk/by-id/scsi-0QEMU_QEMU_HARDDISK_0e99e7db-b97d-4017-a'] failed: Could not remove physical volume /dev/sdb from volume group 'vg1'; this physical volume may be in use and may require a manual data migration (using pvmove) before it can be removed (Execution of '/usr/sbin/vgreduce vg1 /dev/sdb' returned 5: Physical volume "/dev/sdb" still in use)