Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when output of lvs has '<' in output, regular expression does not account for lead character #264

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Rthur
Copy link

@Rthur Rthur commented Apr 24, 2021

Sample output of system where size_to_bytes fails:

$ sudo lvs
LV VG Attr LSize Pool Origin Data% Meta% Move Log Cpy%Sync Convert
root rhel -wi-ao---- <21.50g
swap rhel -wi-ao---- 2.50g

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2021

Codecov Report

Merging #264 (1439cd8) into master (cada6d4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #264   +/-   ##
=======================================
  Coverage   72.96%   72.96%           
=======================================
  Files          17       17           
  Lines         773      773           
=======================================
  Hits          564      564           
  Misses        209      209           
Impacted Files Coverage Δ
lib/facter/lvm_support.rb 70.58% <0.00%> (-5.89%) ⬇️
lib/facter/logical_volumes.rb 100.00% <0.00%> (+11.11%) ⬆️
lib/facter/physical_volumes.rb 100.00% <0.00%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cada6d4...1439cd8. Read the comment docs.

@CLAassistant
Copy link

CLAassistant commented Sep 1, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants