Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow modifying the physical extent size for volume groups #333

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Allow modifying the physical extent size for volume groups #333

merged 2 commits into from
Apr 12, 2024

Conversation

glangloi
Copy link
Contributor

@glangloi glangloi commented Mar 20, 2024 •
edited
Loading

Summary

Allow modifying the physical extent size when creating new volume groups.

Related Issues (if any)

Essentially replaces #332

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@glangloi glangloi requested review from bastelfreak and a team as code owners March 20, 2024 16:01
@CLAassistant
Copy link

CLAassistant commented Mar 20, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@glangloi
Copy link
Contributor Author

glangloi commented Apr 5, 2024

This is now ready to go.

@bastelfreak
Copy link
Collaborator

@glangloi can you please rebase to get rid of the merge commit?

@glangloi
Copy link
Contributor Author

@bastelfreak Is there anything I need to do to get this approved and merged? Thanks!

@bastelfreak bastelfreak merged commit 2cb0893 into puppetlabs:main Apr 12, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
community feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glangloi @CLAassistant @bastelfreak