Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for lvs to be created on specific pv #335

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Elbandi
Copy link

@Elbandi Elbandi commented Apr 23, 2024

Summary

This change allows the use of physical_volume as argument to logical_volume so that the new lv will be created on a specific physical volume even if the volume group consists of several physical volumes.

Sample

    physical_volume { '/dev/sdb':
        ensure => present,
    }
    physical_volume { '/dev/sdc':
        ensure => present,
    }
    physical_volume { '/dev/sdd':
        ensure => present,
    }
    volume_group { 'lvmvg':
        ensure           => present,
        physical_volumes => [ '/dev/sdb', '/dev/sdc', '/dev/sdd']
    }
    logical_volume { 'testpool':
        poolmetadatasize => '256m',
        extents => "100%FREE",
        thinpool => true,
        volume_group => "lvmvg",
        physical_volume => [ "/dev/sdc", "/dev/sdd" ]
    }

Related Issues

This is an updated and tweaked version of #212.

@Elbandi Elbandi requested review from bastelfreak and a team as code owners April 23, 2024 15:06
@CLAassistant
Copy link

CLAassistant commented Apr 23, 2024

CLA assistant check
All committers have signed the CLA.

@Elbandi
Copy link
Author

Elbandi commented Apr 26, 2024

Sould i squash the commits?

@malikparvez
Copy link
Member

Hey @Elbandi could you please resolve the conflicts and write the specs for the change...

@Elbandi
Copy link
Author

Elbandi commented Jul 23, 2024

Hey @Elbandi could you please resolve the conflicts and write the specs for the change...

Resolved, and added a spec (I didn't know what to add... )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants