[Scripts] Make removeAnchors script support Darwin's BSD find #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the
removeAnchorsbash script the GNUfindcommand is assumed. On some operating systems (and I'm mainly thinking about macOS here) the BSDfindis the one available out-of-the-box. The BSDfinddoes not support the-regextypeflag. As a consequence, anyone who runs the script using that command variant will encounter an error.I updated the script to check for the OS and use the appropriate command version so that the script can be a tad more universal. 🙂
edit: I see that this PR can address the first bullet point of #396