Update to jsPsych 7 #35
Conversation
|
@jkhartshorne I think e7d4eed fixes the line ending problem. It runs the shell script through I tested on a clean install of the entire pushkin process on a new windows machine. Everything worked using this experiment template and my modified base site template. I'm still running into at least one unrelated issue with the startExperiment API. I'll see if I can debug that before this is merged. |
|
Have you seen this error before? I'm a bit stumped on where to look: |
|
@jodeleeuw Can you give a bit more detail about running 
Also, if I wanted to use a custom plugin, would the guidance here (https://languagelearninglab.gitbook.io/pushkin/advanced/modifying-experiment-templates#adding-custom-jspsych-plugins) still apply? |
|
Hey @jessestorbeck what version of the cli are you using? I think that error is a cli error that Josh H fixed during the hackathon |
I think the second item on this list is a bit out of date with jsPsych 7 plugins. Our templates should handle the appropriate jsPsych imports, and we don't want to import The import jsPsychMovingWindow from './jspsych-moving-window.js';This will match the syntax in the sample experiment. |
|
@jodeleeuw I'm running version 3.0.2 of the CLI (I believe this was the latest as of the first day of the hackathon). |
|
Try updating to the most recent, I think it is 3.0.7ish. i bet that will solve this issue. |
|
Another possible issue is that I think @jessestorbeck might not be using the updated site template. That pull request (pushkin-consortium/pushkin-sitetemplate-basic#4) is still open (I'm looking at it now). |
|
UPDATE: I've merged pushkin-consortium/pushkin-sitetemplate-basic#4 and released a new version of the basic site template using that update. So you shouldn't need to use the path install; you can install directly using the CLI. |
|
@jodeleeuw @jkhartshorne Aha, I was not using the updated site template. I will download the newest version and try with the updated site template. |
|
This broke the Jest tests, though. I'm going to post an issue to have them fixed. |
|
@jkhartshorne I'm guessing the merge means that you are not also getting an API error that I mentioned above? |
|
@jodeleeuw sorry, I overlooked that. No, it's working fine for me. But I also merged the master into this branch first, so maybe there was something missing? I just published the new version of the experiment template. Maybe try re-installing the site and experiment and make sure you are still getting the error? |
|
Error is gone on a clean install of site template 0.2 and exp template 5.0! 🥳 |
|
I'm getting an error when I try to install the new exp template:
|
|
That's a Windows thing. So what's going on is that during installation
(especially during `yarn install`) enormous numbers of files get opened.
And Windows has a limit on how many. We can increase that limit, which
we did before and that seemed to decrease the frequency of this problem.
But obviously not enough.
Try running `install site` again and see if it happens again. It may be
probabilistic. If it happens again, then try rebooting and then running
install again. I don't really think that'll work, but it might.
Otherwise, I deputize you to read online about this error. I've
forgotten how to increase the open file limit, so you can maybe track
that down.
On July 19, 2023, Sebastian Waz ***@***.***> wrote:
I'm getting an error when I try to install the new exp template:
> ***@***.*** jessePushkinSite % pushkin install
> experiment
> ? What do you want to call your experiment? wordAssociation
> ? Which experiment template do you want to use? basic
> ? Which version? (Recommend:v5.0.0) v5.0.0
> Making wordAssociation in
> /Users/jessestorbeck/Desktop/jessePushkinSite/experiments
> retrieving from <https://api.github.com/repos/pushkin-
> consortium/pushkin-exptemplates-basic/releases/112689021>
> be patient...
> finished downloading
> Error occurred: [Error: EMFILE: too many open files, open
> '/Users/jessestorbeck/Desktop/jessePushkinSite/experiments/wordAssociation/worker/node_modules/core-
> js/full/string/starts-with.js'] {
> errno: -24,
> code: 'EMFILE',
> syscall: 'open',
> path:
> '/Users/jessestorbeck/Desktop/jessePushkinSite/experiments/wordAssociation/worker/node_modules/core-
> js/full/string/starts-with.js'
> }
> Could not read migrations folder
> node:fs:1533
> handleErrorFromBinding(ctx);
> ^
>
> Error: EMFILE: too many open files, scandir
> '/Users/jessestorbeck/Desktop/jessePushkinSite/experiments/wordAssociation/migrations'
> at Object.readdirSync (node:fs:1533:3)
> at _callee2$
> (/Users/jessestorbeck/.config/yarn/global/node_modules/pushkin-
> cli/build/commands/experiments/index.js:380:44)
> at tryCatch
> (/Users/jessestorbeck/.config/yarn/global/node_modules/regenerator-
> runtime/runtime.js:64:40)
> at Generator.invoke
> (/Users/jessestorbeck/.config/yarn/global/node_modules/regenerator-
> runtime/runtime.js:299:22)
> at Generator.throw
> (/Users/jessestorbeck/.config/yarn/global/node_modules/regenerator-
> runtime/runtime.js:124:21)
> at asyncGeneratorStep
> (/Users/jessestorbeck/.config/yarn/global/node_modules/pushkin-
> cli/build/commands/experiments/index.js:42:103)
> at _throw
> (/Users/jessestorbeck/.config/yarn/global/node_modules/pushkin-
> cli/build/commands/experiments/index.js:44:291) {
> errno: -24,
> syscall: 'scandir',
> code: 'EMFILE',
> path:
> '/Users/jessestorbeck/Desktop/jessePushkinSite/experiments/wordAssociation/migrations'
> }
>
> Node.js v20.3.1
>
—
Reply to this email directly, view it on GitHub
<https://github.com/pushkin-consortium/pushkin-exptemplates-
basic/pull/35#issuecomment-1642615235>, or unsubscribe
<https://github.com/notifications/unsubscribe-
auth/ABOVVY2R3GQ5KP2VZYOK6X3XRAWTPANCNFSM6AAAAAAZXG6C5M>.
You are receiving this because you were mentioned.Message ID: <pushkin-
***@***.***>
…--
Sent with HEY <https://hey.com/sent>
|
|
@jkhartshorne This is on my Mac, and Adam got the same error on the lab Mac mini when trying v5.0.0 of the exp template. Incidentally, v4.0.0 will run. I've rebooted and tried |
|
On a hunch, try running docker system prune. See if that helps any.
On July 19, 2023, Sebastian Waz ***@***.***> wrote:
@jkhartshorne <https://github.com/jkhartshorne> This is on my Mac, and
Adam got the same error on the lab Mac mini when trying v5.0.0 of the
exp template. Incidentally, v4.0.0 will run. I've rebooted and tried
install experiment with v5.0.0 a few times, and I get the same error.
This problem doesn't seem to be probabilistic, unlike the errors I've
gotten with install site (see pushkin-consortium/pushkin-cli#110
<pushkin-consortium/pushkin-cli#110>). I did
eventually get install site to run today, which is why I was able to
move on to install experiment. I'll see what I can dig up on Error:
EMFILE.
—
Reply to this email directly, view it on GitHub
<https://github.com/pushkin-consortium/pushkin-exptemplates-
basic/pull/35#issuecomment-1642703068>, or unsubscribe
<https://github.com/notifications/unsubscribe-
auth/ABOVVYY2LPOFY6MECMQMK5DXRA6ZVANCNFSM6AAAAAAZXG6C5M>.
You are receiving this because you were mentioned.Message ID: <pushkin-
***@***.***>
…--
Sent with HEY <https://hey.com/sent>
|
|
However, I tried it a few more times, and on the last try, it ran without any errors. I was then able to run
Here's the full output for one of the errors I got running
|
|
Interesting. A couple things:
As far as the other issues, I'm really not sure. I don't think the answers to Qs 1 & 2 will actually tell me what's wrong, but I want to rule out a couple things. |
|
@jkhartshorne For the CLI, I'm running release 3.0.7. This is on a MacBook Air (Retina, 13-inch, 2020) with an Intel chip (1.1 GHz Quad-Core Intel Core i5) running MacOS 12.4. |
|
I ran it after editing the experiment.js with a few more trials and after adding a different plugin: survey-text and it all compiled and worked out great in localhost. |
|
@ayang21 -- can you compare what you are doing with what @jessestorbeck is doing and see if you can find a difference that might explain his difficulties? |
Confirming that you are
Confirming that you are not using a local copy of the CLI, but the npm release 3.0.7. |
|
@jkhartshorne Correct, it's the npm release. |
This updates the basic template to jsPsych 7.
Before merging, I would recommend adding in docs changes. Folks will need to use
yarn addfor each jsPsych plugin that they want to include. Theexperiment.jsfile also returns a function that generates the timeline. This is so that you can pass the reference tojsPsychinto the function and usejsPsychscoped methods as you construct the timeline.I've got a react hooks based version of this too, but it isn't tested yet.