-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: decidim geo #439
Feat: decidim geo #439
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here some pointers on what I have done @Kagemaru
|
||
BUNDLED WITH | ||
2.5.6 | ||
2.3.20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This use the same bundler version than decidim 0.27.6 uses.
@@ -7,6 +7,9 @@ | |||
# Ignore bundler config. | |||
/.bundle | |||
|
|||
# Ignore deface precompiled views | |||
app/compiled_views |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We propose to avoid adding compiled_views in git. This way, you can run your application in development without both "deface rendering" and "deface precompiled files".
We add the precompilation in entrypoint to be sure deface is precompiled before starting.
This precompilation MUST be done on each redeploy ;)
Hey @froger The Dockerfile in the root directory is the one currently used for deployment. The files in The deployment Dockerfile already includes the libgeos-dev package. The feedback about the deface usage is very welcome. We haven't really done much with it yet. |
This PR add
decidim-decidim_geo
version0.2.3
. We join with this PR configuration to enable working better with the decidim-geo module:libgeos-dev
in the dockerfile See rgeo documentationDEFACE_ENABLE
environment variable to enable dynamic deface resolution on demandpackage.json
andyarn.lock
Gemfile
andGemfile.lock
Some notes:
hfroger/decidim
). It is possible that bundler version does not match the ones you use.libgeos-dev
might just work, but we did not tests without a full-featuredrgeos
gem.Thanks,
Hadrien