Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: decidim geo #439

Merged
merged 4 commits into from
Jun 11, 2024
Merged

Feat: decidim geo #439

merged 4 commits into from
Jun 11, 2024

Conversation

froger
Copy link

@froger froger commented Jun 5, 2024

This PR add decidim-decidim_geo version 0.2.3. We join with this PR configuration to enable working better with the decidim-geo module:

  • Add native dependancy libgeos-dev in the dockerfile See rgeo documentation
  • Handle correctly deface in production with:
    1. a deface pre-compilation in entrypoint
    2. a DEFACE_ENABLE environment variable to enable dynamic deface resolution on demand
  • update the package.json and yarn.lock
  • update the Gemfile and Gemfile.lock

Some notes:

  1. We have tested with our Decidim images (hfroger/decidim). It is possible that bundler version does not match the ones you use.
  2. Running without libgeos-dev might just work, but we did not tests without a full-featured rgeos gem.

Thanks,
Hadrien

Copy link
Author

@froger froger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here some pointers on what I have done @Kagemaru


BUNDLED WITH
2.5.6
2.3.20
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This use the same bundler version than decidim 0.27.6 uses.

@@ -7,6 +7,9 @@
# Ignore bundler config.
/.bundle

# Ignore deface precompiled views
app/compiled_views
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We propose to avoid adding compiled_views in git. This way, you can run your application in development without both "deface rendering" and "deface precompiled files".

We add the precompilation in entrypoint to be sure deface is precompiled before starting.
This precompilation MUST be done on each redeploy ;)

@froger froger mentioned this pull request Jun 5, 2024
@Kagemaru
Copy link
Member

Kagemaru commented Jun 11, 2024

Hey @froger

The Dockerfile in the root directory is the one currently used for deployment. The files in .docker are used for the docker-compose development workflow used by @carlobeltrame.

The deployment Dockerfile already includes the libgeos-dev package.
I'll incorporate the other changes into that Dockerfile after merging and try to deploy it.

The feedback about the deface usage is very welcome. We haven't really done much with it yet.

@Kagemaru Kagemaru merged commit 3d14972 into puzzle:master Jun 11, 2024
1 check passed
@froger froger deleted the feat/decidim-geo branch June 12, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants