Update Angular to 19 #1241
Merged
Update Angular to 19 #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
nevio18324
force-pushed
the
feature/1070-angular-19
branch
from
7fec487 to
8758845
Compare
nevio18324
requested review from
ManuelMoeri
and removed request for
ManuelMoeri
nevio18324
commented
Dec 12, 2024
frontend/src/app/components/application-banner/application-banner.component.scss
Outdated
Show resolved
Hide resolved
frontend/src/app/components/application-top-bar/application-top-bar.component.scss
Outdated
Show resolved
Hide resolved
frontend/src/app/components/checkin/check-in-form-ordinal/check-in-form-ordinal.component.scss
Outdated
Show resolved
Hide resolved
frontend/src/app/components/keyresult-detail/keyresult-detail.component.scss
Outdated
Show resolved
Hide resolved
frontend/src/app/components/keyresult-type/keyresult-type.component.scss
Outdated
Show resolved
Hide resolved
frontend/src/app/shared/custom/dialog-template-core/dialog-template-core.component.scss
Outdated
Show resolved
Hide resolved
frontend/src/app/shared/custom/dialog-template-core/dialog-template-core.component.scss
Outdated
Show resolved
Hide resolved
This was referenced Dec 13, 2024
There was a problem hiding this comment.
LGTM so far
This is gonna need a rebase and also an approval from @peggimann, then we're good to go.
nevio18324
force-pushed
the
feature/1070-angular-19
branch
2 times, most recently
from
8c6b370 to
e6217b8
Compare
|
Don't forget to bump all the dependencies once more before merging this. |
This was referenced Dec 20, 2024
nevio18324
force-pushed
the
feature/1070-angular-19
branch
4 times, most recently
from
ad4173d to
9a01154
Compare
nevio18324
force-pushed
the
feature/1070-angular-19
branch
from
02e50b2 to
cae1ab1
Compare
peggimann
requested changes
Dec 30, 2024
fix as much deprecations as possible make all components, pipes and directives not standalone rename scss files to use underscore and make new scss work fix bootstrap theme not working anymore and fix bug caused by this and simplify path used to access _variables.scss remove the this from all variables/functions inside templates because its deprecated fix another scss deprecation because you shouldnt have declerations after nested rules override glob so newest glob version gets used instead of deprecated version make sidepanel not fullscreen make all filepaths used in @use consistent override jsdom version to remove all deprecations make filepaths in scss @use all the same change import to use remove not needed variable declerations add comment to why intellij shows an error use interpolation in calc methods that use vars and namespaces fix faults made while rebasing remove override and update setup-jest.ts update package lock remove unused jest dependency update npm version to 11.0.0 regen package-lock regen package-lock run formatter and turn prefer standalone rule off
peggimann
force-pushed
the
feature/1070-angular-19
branch
from
c8fe726 to
aed1568
Compare
peggimann
force-pushed
the
feature/1070-angular-19
branch
from
3412a9b to
d6e7c18
Compare
peggimann
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.