Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Indonesia tutorial #1241

Merged
merged 8 commits into from
Aug 19, 2024
Merged

Conversation

odhyp
Copy link

@odhyp odhyp commented Aug 17, 2024

From #267

Checklist:

  • The GitHub pipeline is OK (green),
    meaning that both pylint (static code analyzer) and black (code formatter) are happy with the changes of this PR.

  • A unit test is covering the code added / modified by this PR

  • This PR is ready to be merged

  • In case of a new feature, docstrings have been added, with also some documentation in the docs/ folder

  • A mention of the change is present in CHANGELOG.md

By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.

@odhyp odhyp requested a review from gmischler as a code owner August 17, 2024 17:08
@gmischler
Copy link
Collaborator

Welcome to fpdf2, @odhyp , and thanks for a valuable translation into yet another language! 👍

There's some integration work that still needs to be done though before it is finished.
Please add a mention/listing in the following files;

It should be pretty obvious how and where (ideally alphabetically ordered) the new entries should be created.

@gmischler
Copy link
Collaborator

@allcontributors please add @odhyp for translation

Copy link

@gmischler

I've put up a pull request to add @odhyp! 🎉

@odhyp
Copy link
Author

odhyp commented Aug 18, 2024

Cool! I'll work on that after I clean up my mess. I forgot to sync my fork (I forked this repo 6 months ago) before pushing my changes

@odhyp
Copy link
Author

odhyp commented Aug 18, 2024

Added a mention/listing in these following files:

  • CHANGELOG.md
  • README.md
  • docs/index.md
  • tutorial/notebook.ipynb
  • mkdocs.yml

@odhyp odhyp requested a review from gmischler August 18, 2024 11:54
CHANGELOG.md Outdated Show resolved Hide resolved
@odhyp odhyp requested a review from gmischler August 18, 2024 14:10
@gmischler
Copy link
Collaborator

Merging now. Thanks for the contribution, @odhyp !

@gmischler gmischler merged commit e603175 into py-pdf:master Aug 19, 2024
11 checks passed
@odhyp odhyp deleted the support/add-indonesia branch August 19, 2024 12:57
@odhyp
Copy link
Author

odhyp commented Aug 19, 2024

Thank you for the review and for merging the PR @gmischler! Glad to contribute 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants