Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding Bengali tutorial #726

Closed
wants to merge 0 commits into from
Closed

adding Bengali tutorial #726

wants to merge 0 commits into from

Conversation

ssavi-ict
Copy link

@ssavi-ict ssavi-ict commented Mar 17, 2023

#267 Added Bengali Tutorial

Checklist:

  • The GitHub pipeline is OK (green),
    meaning that both pylint (static code analyzer) and black (code formatter) are happy with the changes of this PR.

  • A unit test is covering the code added / modified by this PR

  • This PR is ready to be merged

  • In case of a new feature, docstrings have been added, with also some documentation in the docs/ folder

  • A mention of the change is present in CHANGELOG.md

By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.

@ssavi-ict ssavi-ict requested a review from Lucas-C as a code owner March 17, 2023 18:05
@ssavi-ict
Copy link
Author

@Lucas-C added Bengali Tutorial.
I have added the information in index.md.
Do I need to add any information in CHANGELOG.md and README.md ?

@Lucas-C
Copy link
Member

Lucas-C commented Mar 18, 2023

Thank you for making this translation @ssavi-ict!

Could you please also add a link in README.md and a mention of this change in CHANGELOG.md?

@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

Patch coverage: 81.35% and project coverage change: -0.97 ⚠️

Comparison is base (35d8e7a) 93.75% compared to head (674ce9c) 92.78%.

❗ Current head 674ce9c differs from pull request most recent head f94fd37. Consider uploading reports for the commit f94fd37 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #726      +/-   ##
==========================================
- Coverage   93.75%   92.78%   -0.97%     
==========================================
  Files          26       27       +1     
  Lines        7009     7245     +236     
  Branches     1258     1307      +49     
==========================================
+ Hits         6571     6722     +151     
- Misses        260      332      +72     
- Partials      178      191      +13     
Impacted Files Coverage Δ
fpdf/__init__.py 100.00% <ø> (ø)
fpdf/svg.py 98.30% <ø> (ø)
fpdf/template.py 90.35% <ø> (ø)
fpdf/util.py 55.88% <41.55%> (-36.72%) ⬇️
fpdf/html.py 87.62% <65.00%> (-7.13%) ⬇️
fpdf/table.py 85.05% <85.05%> (ø)
fpdf/enums.py 97.89% <87.09%> (-2.11%) ⬇️
fpdf/actions.py 89.58% <100.00%> (-1.65%) ⬇️
fpdf/annotations.py 98.63% <100.00%> (-0.02%) ⬇️
fpdf/encryption.py 96.27% <100.00%> (+0.06%) ⬆️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ssavi-ict
Copy link
Author

ssavi-ict commented Mar 18, 2023

@Lucas-C updated CHANGELOG and README. Please have a look.

@ssavi-ict
Copy link
Author

Hello, @Lucas-C . Please let me know if there is any issue with this PR. I did not get any ack yet.

@Lucas-C
Copy link
Member

Lucas-C commented Mar 24, 2023

Hi @ssavi-ict!

You PR is excellent, thank you for submitting it 😊

The reason why I haven't merged it yet is that I am currently working on a big PR: #703
This PR will introduce a new table() method, and hence the section 5 of the tutorial will change a lot:

Would you be OK to adapt your PR in order to use the new version of this section 5, from the English tutorial?

@ssavi-ict
Copy link
Author

ssavi-ict commented Mar 24, 2023

Thank You, @Lucas-C.
I would love to. Please notify me in this issue #267 once the Section 5 English tutorial is ready. I will move to make a translation of Section 5

@shindodkar
Copy link

shindodkar commented Mar 27, 2023

Hi, @ssavi-ict I am new to open source project . So, will you guide me on this project. I also wanna be a Competitive Programmer. So , would you help me how to start and where to start?

@Lucas-C
Copy link
Member

Lucas-C commented Mar 27, 2023

Hi @ssavi-ict!

Just a heads-up: PR #703 has been merged 😊

@ssavi-ict
Copy link
Author

@Lucas-C Thanks for notifying me. Will start working on it soon.

@ssavi-ict
Copy link
Author

@Lucas-C Could you please check the current PR? Updated with recent Tutorial changes.

@Lucas-C
Copy link
Member

Lucas-C commented Mar 27, 2023

@Lucas-C Could you please check the current PR? Updated with recent Tutorial changes.

This looks great!
There may just be a small issue with CHANGELOG.md...
Could you rebase your branch on this repo master branch?
Or else just drop this file from your PR, and I'll update it myself 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants