feat(act 1): activity 1 - clean code basics #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ucodery
reviewed
Oct 7, 2024
|
|
||
| * provide it with descriptive, leading prompts that allow it to perform the task better. So you might write: | ||
|
|
||
| > Make the variables in the code below. |
willingc
reviewed
Oct 7, 2024
@willingc 😆 do you mean the code snippet that is the basis for the activity? 🙃 if so - i know - it is really hard to publish something like that now. |
|
@all-contributors please add @ucodery for review |
|
I've put up a pull request to add @ucodery! 🎉 |
Co-authored-by: Carol Willing <[email protected]>
Co-authored-by: Carol Willing <[email protected]>
Co-authored-by: Carol Willing <[email protected]>
Co-authored-by: Carol Willing <[email protected]>
|
Ok friends - thank you for the reviews!! There will be one htmlproofer error here that will be fixed in #13 All of the other suggestions and edits have been implemented! 🚀 i will merge this when ci is complete! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a single PR that adds the first activity to our lessons. It is ready for review if anyone would like to have a look.