Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make function lesson render #60

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Conversation

lwasser
Copy link
Member

@lwasser lwasser commented Oct 23, 2024

This just fixes the lesson so it renders. I think we should refactor this lesson to be about more

  1. more complex functions.
  2. nesting unctions together in workflows.
  3. Introduce the concept of a script with a main() function.

We might be able to take some of the intro multi parameter stuff and move it to the write-functions lesson.

And then finally, i think some graphics that really help users understand namespaces and what happens when a function runs vs the outputs of a script... theses are just ideas that could become an issue that we address later.

Comment on lines 58 to 68
def multiply_values
def multiply_values(x, y):
```

Next, provide two placeholder variable names for the input parameters, as shown below.

```python
def multiply_values(x, y):

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think someone got lost

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@willingc willingc self-requested a review October 23, 2024 02:38
Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the comment flagged by @sneakers-the-rat

@lwasser lwasser merged commit 0344e2c into pyOpenSci:main Oct 23, 2024
1 of 2 checks passed
@lwasser lwasser deleted the functions2 branch October 23, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants