An aside on function composition #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwasser
reviewed
Oct 24, 2024
| @@ -189,6 +189,16 @@ def mean_mm_to_in(data_mm, axis_value): | |||
|
|
|||
| Note that the function could be written to convert the values first and then calculate the mean. However, given that the function will complete both tasks and return the mean values in the desired units, it is more efficient to calculate the mean values first and then convert just those values, rather than converting all of the values in the input array. | |||
|
|
|||
| ````{tip} | |||
| Typically functions should have a [single purpose](https://en.wikipedia.org/wiki/Separation_of_concerns), and be [composed](https://en.wikipedia.org/wiki/Function_composition_(computer_science)) to implement higher-order operations. The above function would normally be written without wrapping {func}`numpy.mean` like this: | |||
There was a problem hiding this comment.
OH YES!! functions should do one thing well. i love this!
lwasser
approved these changes
Oct 24, 2024
|
thank you!! i'll try my best to slow down a bit as well!! |
|
I would never tell you to slow down! |
|
@sneakers-the-rat you are the best. I appreciate you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing: #58
Just a quick aside with some links to some wikipedia pages for further reading. I think this is good to introduce here for reasons that are along the same lines as what i was saying re: "try/except? that's great! so now i'm going to wrap everything in try/except and now no more errors!" - we don't want the students to overgeneralize and pack everything into big functions :)