Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of NCH (Nearest Convex Hull) classifier #253

Merged
merged 47 commits into from
Mar 18, 2024
Merged

Implementation of NCH (Nearest Convex Hull) classifier #253

merged 47 commits into from
Mar 18, 2024

Commits on Mar 4, 2024

  1. Initial version of NearestConvexHull.

    @toncho11
    toncho11 committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    624e942 View commit details
    Browse the repository at this point in the history

  2. Added script for testing.

    @toncho11
    toncho11 committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    cf3f6d9 View commit details
    Browse the repository at this point in the history

  3. First version that runs.

    @toncho11
    toncho11 committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    fd85f0a View commit details
    Browse the repository at this point in the history

  4. Improved code.

    @toncho11
    toncho11 committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    4548b78 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Added support for parallel processing. 

    It gives an error: AttributeError: Pipeline has none of the following attributes: decision_function.
    @toncho11
    toncho11 committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    0de3c40 View commit details
    Browse the repository at this point in the history

  2. renamed

    @toncho11
    toncho11 committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    37491eb View commit details
    Browse the repository at this point in the history

  3. New version that uses a new class that implements a NCH classifier.

    @toncho11
    toncho11 committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    1c1d17b View commit details
    Browse the repository at this point in the history

  4. small update

    @toncho11
    toncho11 committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    dc5633e View commit details
    Browse the repository at this point in the history

  5. Merge branch 'pyRiemann:main' into main

    @toncho11
    toncho11 authored Mar 5, 2024
    Configuration menu
    Copy the full SHA
    1c4ae29 View commit details
    Browse the repository at this point in the history

  6. Updated to newest code - the new version of the distance function. 

    Added an example that runs on a small number of test samples, so that we can get results quicker.
    @toncho11
    toncho11 committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    e07cd39 View commit details
    Browse the repository at this point in the history

  7. [pre-commit.ci] auto fixes from pre-commit.com hooks

    @pre-commit-ci
    pre-commit-ci[bot] committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    a80ea8d View commit details
    Browse the repository at this point in the history

  8. reinforce constraint on weights

    @gcattan
    gcattan authored Mar 5, 2024
    Configuration menu
    Copy the full SHA
    0f8136f View commit details
    Browse the repository at this point in the history

  9. - remove constraints on weights 

    - limite size of training set
- change to slsqp optimizer
    Gregoire Cattan committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    f7cbe9f View commit details
    Browse the repository at this point in the history

  10. [pre-commit.ci] auto fixes from pre-commit.com hooks

    @pre-commit-ci
    pre-commit-ci[bot] committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    60f5d58 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Added n_max_hull parameter. MOABB support tested.

    @toncho11
    toncho11 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    9aa2fb4 View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks

    @pre-commit-ci
    pre-commit-ci[bot] committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    66aaca1 View commit details
    Browse the repository at this point in the history

  3. added multiple hulls.

    @toncho11
    toncho11 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    f4f02bf View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Multiple hull support. Stash and merge. 

    Merge branch 'main' of https://github.com/toncho11/pyRiemann-qiskit-rep
    @toncho11
    toncho11 committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    4465fc8 View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks

    @pre-commit-ci
    pre-commit-ci[bot] committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    c9357cb View commit details
    Browse the repository at this point in the history

  3. Code cleanups. 

    Added second parameter that specifies the number of hulls.
    @toncho11
    toncho11 committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    8ab59af View commit details
    Browse the repository at this point in the history

  4. [pre-commit.ci] auto fixes from pre-commit.com hooks

    @pre-commit-ci
    pre-commit-ci[bot] committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    3ae1b1e View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Improved code. 

    Added support for transform().
Added a new pipeline [NCH+LDA]
    @toncho11
    toncho11 committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    d7c6e1a View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks

    @pre-commit-ci
    pre-commit-ci[bot] committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    4e8be61 View commit details
    Browse the repository at this point in the history

  3. updated default parameters

    @toncho11
    toncho11 committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    f4f836c View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. General improvements. 

    Improvements requested by GC.
    @toncho11
    toncho11 committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    4d20109 View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks

    @pre-commit-ci
    pre-commit-ci[bot] committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    edc3561 View commit details
    Browse the repository at this point in the history

  3. removed commented code

    @toncho11
    toncho11 committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    1ffc5bc View commit details
    Browse the repository at this point in the history

  4. Small adjustments.

    @toncho11
    toncho11 committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    705164b View commit details
    Browse the repository at this point in the history

  5. Better class separation.

    @toncho11
    toncho11 committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    c562d2a View commit details
    Browse the repository at this point in the history

  6. [pre-commit.ci] auto fixes from pre-commit.com hooks

    @pre-commit-ci
    pre-commit-ci[bot] committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    b9d30fc View commit details
    Browse the repository at this point in the history

  7. Added support for n_samples_per_hull = -1 which takes all the samples… 

    … for a class.
    @toncho11
    toncho11 committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    25bed43 View commit details
    Browse the repository at this point in the history

  8. [pre-commit.ci] auto fixes from pre-commit.com hooks

    @pre-commit-ci
    pre-commit-ci[bot] committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    8eae303 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Update pyriemann_qiskit/classification.py 

    Set of SPD matrices.

Co-authored-by: Quentin Barthélemy <[email protected]>
    @toncho11 @qbarthelemy
    toncho11 and qbarthelemy authored Mar 13, 2024
    Configuration menu
    Copy the full SHA
    f0d5153 View commit details
    Browse the repository at this point in the history

  2. Update pyriemann_qiskit/classification.py 

    Added new lines to before Parameters

Co-authored-by: Quentin Barthélemy <[email protected]>
    @toncho11 @qbarthelemy
    toncho11 and qbarthelemy authored Mar 13, 2024
    Configuration menu
    Copy the full SHA
    1d458c9 View commit details
    Browse the repository at this point in the history

  3. Update pyriemann_qiskit/classification.py 

    [y == c, :, :] => [y == c]

Co-authored-by: Quentin Barthélemy <[email protected]>
    @toncho11 @qbarthelemy
    toncho11 and qbarthelemy authored Mar 13, 2024
    Configuration menu
    Copy the full SHA
    a3533e4 View commit details
    Browse the repository at this point in the history

  4. Update pyriemann_qiskit/classification.py 

    NearestConvexHull text change

Co-authored-by: Quentin Barthélemy <[email protected]>
    @toncho11 @qbarthelemy
    toncho11 and qbarthelemy authored Mar 13, 2024
    Configuration menu
    Copy the full SHA
    94e91b9 View commit details
    Browse the repository at this point in the history

  5. Improvements proposed by Quentin.

    @toncho11
    toncho11 committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    a3cde26 View commit details
    Browse the repository at this point in the history

  6. [pre-commit.ci] auto fixes from pre-commit.com hooks

    @pre-commit-ci
    pre-commit-ci[bot] committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    32bc8a3 View commit details
    Browse the repository at this point in the history

  7. Added comment for the optimizer.

    @toncho11
    toncho11 committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    3676e63 View commit details
    Browse the repository at this point in the history

  8. [pre-commit.ci] auto fixes from pre-commit.com hooks

    @pre-commit-ci
    pre-commit-ci[bot] committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    a040bed View commit details
    Browse the repository at this point in the history

  9. Added some comments in classification. 

    Changes about the global optimizer so, that it is more evident that a global one is used.
    @toncho11
    toncho11 committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    b9837ae View commit details
    Browse the repository at this point in the history

  10. [pre-commit.ci] auto fixes from pre-commit.com hooks

    @pre-commit-ci
    pre-commit-ci[bot] committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    01d655c View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Implemented min hull. 

    Added support for both "min-hull" and "random-hull" using the constructor parameter "hull-type".
    @toncho11
    toncho11 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    1eac251 View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks

    @pre-commit-ci
    pre-commit-ci[bot] committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    67d3dc4 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Reverted to previous version as requested by Gregoire.

    @toncho11
    toncho11 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    fe9deb1 View commit details
    Browse the repository at this point in the history

  2. fix lint issues

    @gcattan
    gcattan authored Mar 18, 2024
    Configuration menu
    Copy the full SHA
    a7da2c5 View commit details
    Browse the repository at this point in the history

  3. [pre-commit.ci] auto fixes from pre-commit.com hooks

    @pre-commit-ci
    pre-commit-ci[bot] committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    7047f46 View commit details
    Browse the repository at this point in the history