Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared interface for electrical interfaces #72

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Guvante
Copy link

@Guvante Guvante commented Dec 7, 2024

  • Added a Turbine.lua to control turbines whose power is controlled dynamically
  • Migrated most of the Aerial.lua code that made sense to share here
  • I believe I successfully duplicated the logic required for the basic wind turbine to work
  • Still a ton of work to be done to migrate tides which haven't been started
  • Still more work to migrate other wind turbines since their prototypes are un-altered
  • 99% certain this will all break due to not properly handling the blanks but haven't looked into that properly yet
  • Need to update GUI when you select one to duplicate the current preview of how effective your wind turbines are
  • Untested and likely completely broken still but figured I would get insight into whether this was a good direction since I needed to take a break for a couple days

Resolves pyanodon/pybugreports#499 (well once I finish the work)

- Added a Turbines that holds most of the logic originally used to
  control accumulators in aerial.lua
- Plan to migrate wind.lua to use it instead of updating each tower
- Blocked on how to handle clicking a power plant...
@Guvante
Copy link
Author

Guvante commented Dec 7, 2024

To reiterate this is totally busted but the shape of what I am doing is done (well still need to figure out GUI but otherwise I think the skeleton is good if untested)

@Guvante Guvante marked this pull request as draft December 7, 2024 00:04
@oorzkws
Copy link
Contributor

oorzkws commented Dec 7, 2024

I'm sorry you had to deal with my aerial code

@oorzkws
Copy link
Contributor

oorzkws commented Dec 7, 2024

By the way, have you seen real-world issues with performance that pyanodon/pybugreports#499 suggests?

@Guvante
Copy link
Author

Guvante commented Dec 7, 2024

Nope I was just going through issues and found one that seemed... "Easy" (?) something that didn't involve balance let's say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tidal and wind need to share electric energy interfaces
2 participants