start refactoring ValidationError in prep for tracking which cert had the error
#11844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
force-pushed
the
validation-error-refactor
branch
from
1da0171
to
d289cd5
Compare
alex
commented
Oct 28, 2024
alex
force-pushed
the
validation-error-refactor
branch
4 times, most recently
from
8785d72
to
e4f53f7
Compare
…ad the error The end goal is that `ValidationError` will include a cert field, which optionally contains a `VerificationCertificate` where relevant refs pyca#11160
alex
force-pushed
the
validation-error-refactor
branch
from
e4f53f7
to
14208f7
Compare
reaperhulk
approved these changes
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The end goal is that
ValidationErrorwill include acertfield, which optionally contains aVerificationCertificatewhere relevantrefs #11160