Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(admissions): implement encoding of admissions extension #11892

Merged
merged 11 commits into from
Nov 7, 2024
Merged

feat(admissions): implement encoding of admissions extension #11892

merged 11 commits into from
Nov 7, 2024

Commits on Nov 7, 2024

  1. feat: implement encoding of admissions extension 

    Signed-off-by: oleg.hoefling <[email protected]>
    @hoefling
    hoefling committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    f12ad74 View commit details
    Browse the repository at this point in the history

  2. chore: add encoding tests 

    Signed-off-by: oleg.hoefling <[email protected]>
    @hoefling
    hoefling committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    77f158a View commit details
    Browse the repository at this point in the history

  3. refactor: split encoding of inner objects into separate functions 

    Signed-off-by: oleg.hoefling <[email protected]>
    @hoefling
    hoefling committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    133402a View commit details
    Browse the repository at this point in the history

  4. fix: simplify code comment to pass the line length checks 

    Signed-off-by: oleg.hoefling <[email protected]>
    @hoefling
    hoefling committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    1cc349a View commit details
    Browse the repository at this point in the history

  5. chore: add test to check encoding of none values 

    Signed-off-by: oleg.hoefling <[email protected]>
    @hoefling
    hoefling committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    3276196 View commit details
    Browse the repository at this point in the history

  6. chore: extend none values test to also check encoding of naming autho… 

    …rity with none values

Signed-off-by: oleg.hoefling <[email protected]>
    @hoefling
    hoefling committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    62fe192 View commit details
    Browse the repository at this point in the history

  7. fix: use none checks when converting python data 

    Signed-off-by: oleg.hoefling <[email protected]>
    @hoefling
    hoefling committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    242361c View commit details
    Browse the repository at this point in the history

  8. fix: raise a valueerror if the url can not be encoded to an ia5string 

    Signed-off-by: oleg.hoefling <[email protected]>
    @hoefling
    hoefling committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    995d166 View commit details
    Browse the repository at this point in the history

  9. chore: revert to truthness check for py_oids for now, will be amended… 

    … in a separate pr

Signed-off-by: oleg.hoefling <[email protected]>
    @hoefling
    hoefling committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    d7cdafa View commit details
    Browse the repository at this point in the history

  10. fix: raise a valueerror if the registration_number can not be encoded… 

    … to a printablestring

Signed-off-by: oleg.hoefling <[email protected]>
    @hoefling
    hoefling committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    8e495a1 View commit details
    Browse the repository at this point in the history

  11. fix: encode none for profession_oids if profession_oids is none 

    Signed-off-by: oleg.hoefling <[email protected]>
    @hoefling
    hoefling committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    526e083 View commit details
    Browse the repository at this point in the history