Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(admissions): add documentation for the admissions extension #11964

Merged
merged 2 commits into from
Nov 16, 2024

Conversation

hoefling
Copy link
Contributor

This should be my last PR for #11875, adding the documentation for the Admissions extension. It was suprisingly hard to describe the types and fields, since the original specification is rather vague and my particular use case of the extension is often too specific to add it (e.g. the extension should have exactly one ProfessionInfo, with exactly one pair of text and OID in the profession_items and profession_oids etc). Therefore, I will gladly rewrite the passages that are less readable or are unclear.

@hoefling
Copy link
Contributor Author

Looks like the CI failed not due to the changes in this PR; added #11965 to address this. Will rebase onto it and retry.

@alex
Copy link
Member

alex commented Nov 16, 2024 via email

@hoefling hoefling force-pushed the feature/extension/admissions/docs branch from c17766f to 27b23a2 Compare November 16, 2024 21:51
Copy link
Member

@alex alex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can send a PR for the changelog, I think that'll be the last piece!

@alex alex merged commit 120583a into pyca:main Nov 16, 2024
59 checks passed
@hoefling hoefling deleted the feature/extension/admissions/docs branch November 16, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants