refactor: replace returning pyobject with bound<'p, pyany> in x509::common::parse_general_name #11976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ommon::parse_general_name Signed-off-by: oleg.hoefling <[email protected]>
alex
approved these changes
Nov 16, 2024
hoefling
deleted the
refactor/remove-pyobject-return-types-in-x509-common-parse-general-name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the continuation of #11966, but for the
x509::common::parse_general_namefunction, that does two things:Result<..., CryptographyError>usages withCryptographyResult<...>, originally suggested by @alex in feat(admissions): implement encoding of admissions extension #11892 (comment)CryptographyResult<pyo3::PyObject>return types byCryptographyResult<pyo3::Bound<'p, pyo3::PyAny>>, originally suggested by @alex in feat(admissions): implement parsing of admissions extension #11903 (comment)