-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate parsing of unencrypted PKCS#8 private keys to Rust #12296
base: main
Are you sure you want to change the base?
Conversation
81ab411
to
66e7aec
Compare
paramiko failures are due to paramiko/paramiko#2490 (probably) |
test cases needed to coverage:
|
daeef67
to
3250d10
Compare
}; | ||
let Some((cipher_algorithm, iv)) = dek_info.split_once(',') else { | ||
todo!() | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alex , could You please make this code (81-86) compatible with Rust 1.63? let...else is unstable in 1.63... :-(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've had an MSRV of 1.65 since cryptography 43.0.0 in July of last year, we're not going to revert that absent exceptional circumstances
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alex , I still maintain my custom build based on Rust 1.63 w/o GATs, maturin & workspace deps. It works fast on my retro systems (Win'7 and earlier) and very stable, too. :-)
Replacement:
let dek_info = match p.headers().get("DEK-Info") {
Some(dek_info) => dek_info,
None => {
todo!()
},
};
let (cipher_algorithm, iv) = match dek_info.split_once(',') {
Some((cipher_algorithm, iv)) => (cipher_algorithm, iv),
None => {
todo!()
},
};
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not going out of our way to to support things that we don't support.
Test cases we need:
|
5fd4c86
to
b72b393
Compare
To be used in pyca#12296
No description provided.