Free threaded support #12555
Draft
Free threaded support #12555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess because I'm not using the |
ngoldbaum
commented
Mar 6, 2025
ngoldbaum
commented
Mar 6, 2025
alex
reviewed
Mar 6, 2025
| @@ -110,6 +110,62 @@ impl PKCS7PaddingContext { | |||
| } | |||
| } | |||
|
|
|||
| #[pyo3::pyclass] | |||
There was a problem hiding this comment.
For this migration, this can go into its own PR -- it can be merged without any of the rest of the freethreading stuff.
There was a problem hiding this comment.
I'll cherrypick the Rust ports and make them their own PRs and keep the free-threading-specific stuff in this PR.
|
Great
…On Thu, Mar 6, 2025 at 5:03 PM Nathan Goldbaum ***@***.***> wrote:
@ngoldbaum commented on this pull request.
________________________________
In src/rust/src/padding.rs:
> @@ -110,6 +110,62 @@ impl PKCS7PaddingContext {
}
}
+#[pyo3::pyclass]
I'll cherrypick the Rust ports and make them their own PRs and keep the free-threading-specific stuff in this PR.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: ***@***.***>
--
All that is necessary for evil to succeed is for good people to do nothing.
|
ngoldbaum
force-pushed
the
free-threaded-support
branch
from
e0636ce to
3028574
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards fixing #12489.
Adds free-threaded CI using a hacky workaround to avoid building against the version of cffi on PyPI.
xref #12590