Rewrite the pyOpenSSL implementation in terms of the cryptography one #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
force-pushed
the
alex-patch-1
branch
6 times, most recently
from
98e3389
to
459c39e
Compare
|
Hmm, I don't understand how this could impact the coverage tests? Motivation here is to clean up usage of deprecated pyOpenSSL APIs that we'd like to remove. |
|
it looks like I haven't fixed the coverage step after one of many GHA compat breaks. let me look real quick |
|
thanks! |
|
ah beautiful! and, if I may say so: pretty cool to have tests in situations like this. |
hynek
approved these changes
Oct 25, 2024
|
@hynek do you have a plan for when the next service-identity release will be? Would like to get people off the deprecated APIs. |
|
I had none, but I can refresh the project (uv ci, metadata, drop old pythons, …) and push a no-other-changes one. |
|
speaking of, there's nothing that could move #20 along, right? |
|
Left a comment with a minor status update there.
…On Fri, Oct 25, 2024 at 9:10 AM Hynek Schlawack ***@***.***> wrote:
speaking of, there's nothing that could move #20
<#20> along, right?
—
Reply to this email directly, view it on GitHub
<#70 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAGBBRNYRP77LQLIS7PVTZ5I7KTAVCNFSM6AAAAABQTGCSPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZXG4ZTQNRWG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
All that is necessary for evil to succeed is for good people to do nothing.
|
|
And re: refreshes/release, that'd be awesome, thanks! |
hynek
added a commit
that referenced
this pull request
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.