Skip to content
This repository has been archived by the owner on Sep 16, 2024. It is now read-only.

BLE update #495

Open
wants to merge 1 commit into
base: Release/v1.20
Choose a base branch
from
Open

BLE update #495

wants to merge 1 commit into from

Conversation

Xykon
Copy link
Member

@Xykon Xykon commented Nov 10, 2020

No description provided.

@Xykon Xykon requested review from peter-pycom and a team November 10, 2020 09:14
Copy link
Contributor

@peter-pycom peter-pycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see one question inline. also please add a commit message that explains why we're doing this. what does it achieve and PR to FD:master

// stop smart config with special event
xEventGroupSetBits(wifi_event_group, ESPTOUCH_SLEEP_STOP_BIT);
vTaskDelay(100/portTICK_PERIOD_MS);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just checking, is it intentional that we do nothing if self_in is bool and False? Or should we set ESPTOUCH_STOP_BIT?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants