Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2.0 url refactor #332

Open
wants to merge 3 commits into
base: v2.0
Choose a base branch
from
Open

V2.0 url refactor #332

wants to merge 3 commits into from

Conversation

ricco386
Copy link
Member

No description provided.

@ricco386 ricco386 self-assigned this Nov 27, 2017
@ricco386 ricco386 requested a review from ZoltanOnody November 27, 2017 08:56
@codecov-io
Copy link

codecov-io commented Nov 27, 2017

Codecov Report

Merging #332 into v2.0 will decrease coverage by 0.08%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##             v2.0     #332      +/-   ##
==========================================
- Coverage   88.69%   88.61%   -0.09%     
==========================================
  Files          31       31              
  Lines        1318     1326       +8     
==========================================
+ Hits         1169     1175       +6     
- Misses        149      151       +2
Impacted Files Coverage Δ
konfera/serializers.py 100% <ø> (ø) ⬆️
konfera/tests/test_views.py 100% <100%> (ø) ⬆️
konfera/models/ticket_type.py 96.05% <100%> (ø) ⬆️
konfera/urls.py 100% <100%> (ø) ⬆️
konfera/views.py 96.07% <77.77%> (-3.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c715fd...ee0b3dc. Read the comment docs.

Copy link
Member

@ZoltanOnody ZoltanOnody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but otherwise LGTM

exclude = []
all_ticket_types = TicketType.objects.filter(event__slug=slug, accessibility=TicketType.PUBLIC)

for ticket_type in all_ticket_types:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines are an ideal candidate for list comprehension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants