Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batson #136

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

make encoder more private

6513df5
Select commit
Loading
Failed to load commit list.
Open

Batson #136

make encoder more private
6513df5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 22, 2024 in 0s

87.58% (-3.36%) compared to 82d7146

View this Pull Request on Codecov

87.58% (-3.36%) compared to 82d7146

Details

Codecov Report

Attention: Patch coverage is 82.44804% with 304 lines in your changes missing coverage. Please review.

Project coverage is 87.58%. Comparing base (82d7146) to head (6513df5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/batson/src/decoder.rs 61.53% 20 Missing and 45 partials ⚠️
crates/batson/src/object.rs 86.60% 33 Missing and 25 partials ⚠️
crates/batson/src/array.rs 87.40% 12 Missing and 36 partials ⚠️
crates/batson/src/header.rs 78.04% 32 Missing and 13 partials ⚠️
crates/batson/src/errors.rs 0.00% 34 Missing ⚠️
crates/batson/src/get.rs 84.69% 16 Missing and 14 partials ⚠️
crates/batson/src/encoder.rs 91.13% 5 Missing and 9 partials ⚠️
crates/batson/src/lib.rs 85.00% 3 Missing and 3 partials ⚠️
crates/batson/src/json_writer.rs 94.66% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
- Coverage   90.94%   87.58%   -3.36%     
==========================================
  Files          12       21       +9     
  Lines        2042     3770    +1728     
  Branches     2042     3770    +1728     
==========================================
+ Hits         1857     3302    +1445     
- Misses        112      248     +136     
- Partials       73      220     +147     
Files with missing lines Coverage Δ
crates/jiter/src/lazy_index_map.rs 97.03% <100.00%> (+1.07%) ⬆️
crates/jiter/src/python.rs 97.43% <100.00%> (ø)
crates/jiter/src/value.rs 82.35% <100.00%> (+0.64%) ⬆️
crates/batson/src/json_writer.rs 94.66% <94.66%> (ø)
crates/batson/src/lib.rs 85.00% <85.00%> (ø)
crates/batson/src/encoder.rs 91.13% <91.13%> (ø)
crates/batson/src/get.rs 84.69% <84.69%> (ø)
crates/batson/src/errors.rs 0.00% <0.00%> (ø)
crates/batson/src/header.rs 78.04% <78.04%> (ø)
crates/batson/src/array.rs 87.40% <87.40%> (ø)
... and 2 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82d7146...6513df5. Read the comment docs.