Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Hyperlint Styles #140

Closed
wants to merge 10 commits into from
Closed

Update Hyperlint Styles #140

wants to merge 10 commits into from

Conversation

bllchmbrs
Copy link

@bllchmbrs bllchmbrs commented Sep 16, 2024

Update Hyperlint styles for #136

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 0.45788% with 1087 lines in your changes missing coverage. Please review.

Project coverage is 61.70%. Comparing base (b09b969) to head (1f58909).
Report is 17 commits behind head on batson.

Files with missing lines Patch % Lines
crates/batson/src/header.rs 0.00% 193 Missing ⚠️
crates/batson/src/array.rs 0.00% 184 Missing ⚠️
crates/batson/src/object.rs 0.00% 180 Missing ⚠️
crates/batson/src/decoder.rs 0.00% 147 Missing ⚠️
crates/batson/src/encoder.rs 0.00% 125 Missing ⚠️
crates/batson/src/get.rs 0.00% 103 Missing ⚠️
crates/batson/src/json_writer.rs 0.00% 71 Missing ⚠️
crates/batson/src/lib.rs 0.00% 39 Missing ⚠️
crates/batson/src/errors.rs 0.00% 30 Missing ⚠️
crates/jiter/src/lazy_index_map.rs 0.00% 15 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           batson     #140       +/-   ##
===========================================
- Coverage   94.55%   61.70%   -32.86%     
===========================================
  Files          12       21        +9     
  Lines        2040     3128     +1088     
===========================================
+ Hits         1929     1930        +1     
- Misses        111     1198     +1087     
Files with missing lines Coverage Δ
crates/jiter/src/python.rs 97.00% <100.00%> (ø)
crates/jiter/src/value.rs 94.11% <100.00%> (+0.01%) ⬆️
crates/jiter/src/lazy_index_map.rs 85.08% <0.00%> (-12.90%) ⬇️
crates/batson/src/errors.rs 0.00% <0.00%> (ø)
crates/batson/src/lib.rs 0.00% <0.00%> (ø)
crates/batson/src/json_writer.rs 0.00% <0.00%> (ø)
crates/batson/src/get.rs 0.00% <0.00%> (ø)
crates/batson/src/encoder.rs 0.00% <0.00%> (ø)
crates/batson/src/decoder.rs 0.00% <0.00%> (ø)
crates/batson/src/object.rs 0.00% <0.00%> (ø)
... and 2 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b09b969...1f58909. Read the comment docs.

Copy link

codspeed-hq bot commented Sep 16, 2024

CodSpeed Performance Report

Merging #140 will not alter performance

Comparing bllchmbrs:batson (1f58909) with batson (c30e649)

Summary

✅ 73 untouched benchmarks

Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pre-commit is complaining about a missing new line at the end of the file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must say I don't love this path, could we not have just one toml file?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback, it's part of the rules engine right now but I'll talk it over with the team and see what we can do.

@samuelcolvin
Copy link
Member

replaced by #142.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants