Support a dataclass type as an argument

pydantic · May 3, 2024 · ac5eae1 · ac5eae1
1 parent 1ac2d9d
commit ac5eae1
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/logfire/_internal/json_schema.py b/logfire/_internal/json_schema.py
@@ -118,7 +118,7 @@ def create_json_schema(obj: Any, seen: set[int]) -> JsonDict:
         return _mapping_schema(obj, seen)
     elif is_sqlalchemy(obj):
         return _sqlalchemy_schema(obj, seen)
-    elif dataclasses.is_dataclass(obj):
+    elif dataclasses.is_dataclass(obj) and not isinstance(obj, type):
         return _dataclass_schema(obj, seen)
     elif is_attrs(obj):
         return _attrs_schema(obj, seen)

diff --git a/tests/test_json_args.py b/tests/test_json_args.py
@@ -809,6 +809,19 @@ class StrSubclass(str):
             },
             id='dict_of_types_in_list',
         ),
+        pytest.param(
+            [MyDataclass],
+            "[<class 'tests.test_json_args.MyDataclass'>]",
+            '["<class \'tests.test_json_args.MyDataclass\'>"]',
+            {
+                'items': {
+                    'type': 'object',
+                    'x-python-datatype': 'unknown',
+                },
+                'type': 'array',
+            },
+            id='list_of_dataclass_type',
+        ),
     ],
 )
 def test_log_non_scalar_args(