Improve the OpenAI integration #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
commented
May 3, 2024
Deploying logfire-docs with
|
| Latest commit: |
d84f8fd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c44cccd4.logfire-docs.pages.dev |
| Branch Preview URL: | https://add-type-hints-on-openai.logfire-docs.pages.dev |
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
samuelcolvin
approved these changes
May 3, 2024
|
|
||
| from ..main import Logfire, LogfireSpan | ||
|
|
||
| _AsyncStreamT = TypeVar('_AsyncStreamT', bound=AsyncStream[Any]) |
There was a problem hiding this comment.
can you add a comment explaining roughly what these do and why they're needed - just one comment for all of them is probably enough.
|
Does this take #54 into account? |
Kludex
force-pushed
the
add-type-hints-on-openai
branch
from
ddaa2db
to
f76ef10
Compare
No. Unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.with_raw_responseis used #62