Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add excluded_urls example for / #487

Merged
merged 13 commits into from
Oct 15, 2024
Merged

Add excluded_urls example for / #487

merged 13 commits into from
Oct 15, 2024

Conversation

sydney-runkle
Copy link
Member

Closes #474

@sydney-runkle sydney-runkle added the documentation Improvements or additions to documentation label Oct 9, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Oct 9, 2024 •
edited
Loading

Deploying logfire-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1bd5c31
Status: ✅  Deploy successful!
Preview URL: https://4f889f2c.logfire-docs.pages.dev
Branch Preview URL: https://exclude-urls.logfire-docs.pages.dev

View logs

@codecov Codecov
Copy link

codecov bot commented Oct 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d88f964) to head (1bd5c31).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #487   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          132       132           
  Lines         9961      9961           
  Branches      1341      1341           
=========================================
  Hits          9961      9961

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sydney-runkle sydney-runkle enabled auto-merge (squash) October 9, 2024 19:13
@sydney-runkle sydney-runkle disabled auto-merge October 9, 2024 19:14
@alexmojaki
Copy link
Contributor

Maybe this should be a section under https://logfire.pydantic.dev/docs/integrations/use-cases/web-frameworks/ which is linked to from specific integrations the way that capturing headers is, since this applies to other integrations as well, not just fastapi.

@sydney-runkle
Copy link
Member Author

Didn't get to this one today, will apply these suggestions tomorrow! Thanks for the feedback, folks!

hyperlint-ai[bot]
hyperlint-ai bot reviewed Oct 11, 2024
View reviewed changes
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7 files reviewed, 2 total issue(s) found.

The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:

  • [Rr]egexes

docs/integrations/use-cases/web-frameworks.md Show resolved Hide resolved
@sydney-runkle
Copy link
Member Author

@alexmojaki, should be ready for review again 👍

alexmojaki
alexmojaki requested changes Oct 14, 2024
View reviewed changes
docs/integrations/asgi.md Show resolved Hide resolved
docs/integrations/use-cases/web-frameworks.md Outdated Show resolved Hide resolved
docs/integrations/use-cases/web-frameworks.md Outdated Show resolved Hide resolved
docs/integrations/use-cases/web-frameworks.md Outdated Show resolved Hide resolved
docs/integrations/wsgi.md Outdated Show resolved Hide resolved
hyperlint-ai[bot]
hyperlint-ai bot reviewed Oct 15, 2024
View reviewed changes
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 files reviewed, 1 total issue(s) found.

docs/integrations/asgi.md Show resolved Hide resolved
alexmojaki
alexmojaki approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@alexmojaki alexmojaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sydney-runkle sydney-runkle enabled auto-merge (squash) October 15, 2024 14:57
hyperlint-ai[bot]
hyperlint-ai bot reviewed Oct 15, 2024
View reviewed changes
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 files reviewed, 1 total issue(s) found.

docs/integrations/asgi.md Show resolved Hide resolved
@sydney-runkle sydney-runkle merged commit 9350571 into main Oct 15, 2024
12 checks passed
@sydney-runkle sydney-runkle deleted the exclude_urls branch October 15, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyperlint-ai hyperlint-ai[bot] hyperlint-ai[bot] left review comments

@dmontagu dmontagu dmontagu approved these changes

@alexmojaki alexmojaki alexmojaki approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document excluding / as an example of excluded_urls
3 participants
@sydney-runkle @alexmojaki @dmontagu