Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docs redirects #556

Merged
merged 1 commit into from
Oct 30, 2024
Merged

fix docs redirects #556

merged 1 commit into from
Oct 30, 2024

Conversation

samuelcolvin
Copy link
Member

We need to be careful about adding redirects for any changes of URL.

image

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f292b38) to head (43326e4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #556   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          132       132           
  Lines        10175     10175           
  Branches      1395      1395           
=========================================
  Hits         10175     10175           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexmojaki alexmojaki requested a review from Kludex October 30, 2024 11:22
@Kludex
Copy link
Member

Kludex commented Oct 30, 2024

Is there a way to enforce this?

@Kludex Kludex merged commit 4615e9d into main Oct 30, 2024
18 checks passed
@Kludex Kludex deleted the fix-docs-redirects branch October 30, 2024 11:37
@samuelcolvin
Copy link
Member Author

Is there a way to enforce this?

Not that I know of, but would be really good if we could.

@Kludex
Copy link
Member

Kludex commented Oct 30, 2024

Is there a way to enforce this?

Not that I know of, but would be really good if we could.

I think we can add a pre-commit hook if a .md file under docs changes only the location, and ask for a change on the redirects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants